1. Forum
  2. FidoNet
  3. GOLDED

  • Golded not showing linedrawing characters after update

    From Wilfred van Velzen@2:280/464 to All on Wed Feb 7 15:32:50 2024
    Hi All,

    I updated from GED+LNX 1.1.5-b20161221 to 1.1.5-b20240205 yesterday. (Compiled it myself using cmake)

    Now linedrawing characters are not showing correctly.

    Here's an example from the STATS area, with the new version:


    - STATS (2:280/464) -------------------------------------------------- STATS -
    Msg : 1310 of 1315
    From : The Pharcyde 1:154/10 2024-02-06 23:59:02
    To : All 2024-02-07 06:59:48
    Subj : Top 10 Areas -1702------------------------------------------------------------------------- @MSGID: 1:154/10 65c31c26
    @PID: hpt/lnx 1.9 2024-02-05
    @TID: hpt/lnx 1.9 2024-02-05
    HPT Statistics
    Wed Dec 31 18:00:00 1969 - Tue Feb 6 23:53:03 2024

    Top 10 Areas
    Area Incoming Outgoing M-DM-DM-DM-DM-DM-DM-DM-DM-DM-DM-DM-DM-DM-DM-DM-D M-ZM-DM-DM-DM-DM-DM-DM-DM-DM- WEATHER M-3M-[M-[M-[M-[M-2M-2M-2M-2M-2M-2M-2M-2M-2M-2M-2M-2M-2M-2M-2M AGN_HUB M-3M-[M-2M-2M-2M-2M-2M-2M-2M-2M-2M-2M-2M-2M-2M-2M-2M-2M-2M-2M COOKING M-3M-[M-[M-2M-2M-2M-2M-2M-2M-2M-2M-2M-2M-2M-2M-2M-2M-2M-2M-2M ...


    Here it is with the old version in a remote putty session:


    ± STATS (2:280/464) ±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±± STATS ±
    Msg : 1310 of 1315
    From : The Pharcyde 1:154/10 2024-02-06 23:59:02
    To : All 2024-02-07 06:59:48
    Subj : Top 10 Areas ±1702±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±± @MSGID: 1:154/10 65c31c26
    @PID: hpt/lnx 1.9 2024-02-05
    @TID: hpt/lnx 1.9 2024-02-05
    HPT Statistics
    Wed Dec 31 18:00:00 1969 - Tue Feb 6 23:53:03 2024

    Top 10 Areas
    Area Incoming Outgoing ±±±±±±±±±±±±±±±± ±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±? ±±±±±±±±±± ±±±±±±±±±± WEATHER ±±±±?±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±± 137k 29.2% 1.6M 30.7% AGN_HUB ±?±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±± 41k 8.7% 1.4M 27.4% COOKING ±±?±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±±± 68k 14.5% 821k 15.2% ...


    And the old version locally in a Konsole terminal, which is the most correct:


    Ä STATS (2:280/464) ÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄ STATS Ä
    Msg : 1310 of 1318
    From : The Pharcyde 1:154/10 2024-02-06 23:59:02
    To : All 2024-02-07 06:59:48
    Subj : Top 10 Areas Ä1702ÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄ @MSGID: 1:154/10 65c31c26
    @PID: hpt/lnx 1.9 2024-02-05
    @TID: hpt/lnx 1.9 2024-02-05
    HPT Statistics
    Wed Dec 31 18:00:00 1969 - Tue Feb 6 23:53:03 2024

    Top 10 Areas
    Area Incoming Outgoing ÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄ ÚÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄ¿ ÄÄÄÄÄÄÄÄÄÄ ÄÄÄÄÄÄÄÄÄÄ WEATHER ³ÛÛÛÛ²²²²²²²²²²²²²²²²²²²²²²²²²²²²²²²²²³ 137k 29.2% 1.6M 30.7% AGN_HUB ³Û²²²²²²²²²²²²²²²²²²²²²²²²²²²²²²²²úúúú³ 41k 8.7% 1.4M 27.4% COOKING ³ÛÛ²²²²²²²²²²²²²²²²²úúúúúúúúúúúúúúúúúú³ 68k 14.5% 821k 15.2%


    How can I fix this with the new version?


    Bye, Wilfred.

    --- FMail-lnx64 2.2.1.0
    * Origin: FMail development HQ (2:280/464)
  • From Nil Alexandrov@1:16/101 to Wilfred van Velzen on Wed Feb 7 18:29:34 2024
    Hello, Wilfred!

    Wednesday February 07 2024 15:32, from Wilfred van Velzen -> All:

    I updated from GED+LNX 1.1.5-b20161221 to 1.1.5-b20240205 yesterday. (Compiled it myself using cmake)
    Now linedrawing characters are not showing correctly.

    Show me your
    echo $LANG @ $TERM @ $LINES @ $COLUMNS

    Best Regards, Nil
    --- GoldED+/LNX 1.1.5
    * Origin: Linux 2.6.32-042stab145.3 (1:16/101)
  • From Wilfred van Velzen@2:280/464 to Nil Alexandrov on Wed Feb 7 16:33:40 2024
    Hi Nil,

    On 2024-02-07 18:29:34, you wrote to me:

    Wednesday February 07 2024 15:32, from Wilfred van Velzen -> All:

    I updated from GED+LNX 1.1.5-b20161221 to 1.1.5-b20240205 yesterday.
    (Compiled it myself using cmake)
    Now linedrawing characters are not showing correctly.

    Show me your
    echo $LANG @ $TERM @ $LINES @ $COLUMNS

    POSIX @ xterm @ 53 @ 156

    This is in my local Konsole terminal.


    Bye, Wilfred.

    --- FMail-lnx64 2.2.1.0
    * Origin: FMail development HQ (2:280/464)
  • From Nil Alexandrov@1:16/101 to Wilfred van Velzen on Wed Feb 7 18:44:12 2024
    Hello, Wilfred!

    Wednesday February 07 2024 15:32, from Wilfred van Velzen -> All:

    I updated from GED+LNX 1.1.5-b20161221 to 1.1.5-b20240205 yesterday. (Compiled it myself using cmake)
    Now linedrawing characters are not showing correctly.

    I suspect that one of the recent patches messed up with the ncurses initialization.

    Here is a temporary workaround for you. Before running GoldED, just run

    tput init

    Best Regards, Nil
    --- GoldED+/LNX 1.1.5
    * Origin: Linux 2.6.32-042stab145.3 (1:16/101)
  • From Vitaliy Aksyonov@1:104/117 to Wilfred van Velzen on Wed Feb 7 08:46:12 2024
    Hello Wilfred.

    07 Feb 24 15:32, you wrote to All:

    I updated from GED+LNX 1.1.5-b20161221 to 1.1.5-b20240205 yesterday. (Compiled it myself using cmake)

    Now linedrawing characters are not showing correctly.

    Could you use git bisect to find the version which has broken this functionality?

    Vitaliy

    --- GoldED+/LNX 1.1.5-b20231030
    * Origin: Aurora, Colorado (1:104/117)
  • From Wilfred van Velzen@2:280/464 to Nil Alexandrov on Wed Feb 7 17:21:34 2024
    Hi Nil,

    On 2024-02-07 18:44:12, you wrote to me:

    I updated from GED+LNX 1.1.5-b20161221 to 1.1.5-b20240205 yesterday.
    (Compiled it myself using cmake)
    Now linedrawing characters are not showing correctly.

    I suspect that one of the recent patches messed up with the ncurses initialization.

    Here is a temporary workaround for you. Before running GoldED, just run

    tput init

    It doesn't help for the linedrawing characters inside a message.

    I'll check tomorrow what happens in a remote terminal.


    Bye, Wilfred.

    --- FMail-lnx64 2.2.1.0
    * Origin: FMail development HQ (2:280/464)
  • From Wilfred van Velzen@2:280/464 to Vitaliy Aksyonov on Wed Feb 7 17:33:30 2024
    Hi Vitaliy,

    On 2024-02-07 08:46:12, you wrote to me:

    I updated from GED+LNX 1.1.5-b20161221 to 1.1.5-b20240205 yesterday.
    (Compiled it myself using cmake)

    Now linedrawing characters are not showing correctly.

    Could you use git bisect to find the version which has broken this functionality?

    I'll try.


    Bye, Wilfred.

    --- FMail-lnx64 2.2.1.0
    * Origin: FMail development HQ (2:280/464)
  • From Vitaliy Aksyonov@1:104/117 to Wilfred van Velzen on Wed Feb 7 09:48:30 2024
    Hello Wilfred.

    07 Feb 24 17:21, you wrote to Nil Alexandrov:

    I updated from GED+LNX 1.1.5-b20161221 to 1.1.5-b20240205
    yesterday. (Compiled it myself using cmake) Now linedrawing
    characters are not showing correctly.

    I suspect that one of the recent patches messed up with the
    ncurses initialization.

    Here is a temporary workaround for you. Before running GoldED,
    just run

    tput init

    It doesn't help for the linedrawing characters inside a message.

    I'll check tomorrow what happens in a remote terminal.

    Could you also thy this pull request https://github.com/golded-plus/golded-plus/pull/52

    It may help. If so, we just push it in master.

    Vitaliy

    --- GoldED+/LNX 1.1.5-b20231030
    * Origin: Aurora, Colorado (1:104/117)
  • From Vitaliy Aksyonov@1:104/117 to Wilfred van Velzen on Wed Feb 7 10:58:58 2024
    Hello Wilfred.

    07 Feb 24 18:14, you wrote to me:

    I updated from GED+LNX 1.1.5-b20161221 to 1.1.5-b20240205
    yesterday. (Compiled it myself using cmake)

    Now linedrawing characters are not showing correctly.

    Could you use git bisect to find the version which has broken
    this functionality?

    I'll try.

    I didn't know about the bisect function in git. Nice function!

    Here's the final output:

    # git bisect good
    8e9f3518ac9b3b32676e7b7563e92cc44e7b5ba7 is the first bad commit
    commit 8e9f3518ac9b3b32676e7b7563e92cc44e7b5ba7
    Author: Vitaliy Aksyonov <gbmr@i.ua>
    Date: Fri Oct 6 10:44:41 2023 -0600

    Thanks. I'll rollback that change.

    Vitaliy

    ... A?o?o?o?u?? - u??e?u?, ????c??o - ?e?.
    --- GoldED+/LNX 1.1.5-b20231030
    * Origin: Aurora, Colorado (1:104/117)
  • From Nil Alexandrov@1:16/101 to Wilfred van Velzen on Wed Feb 7 21:00:50 2024
    Hello, Wilfred!

    Wednesday February 07 2024 18:42, from Wilfred van Velzen -> Vitaliy Aksyonov:

    Could you also thy this pull request
    https://github.com/golded-plus/golded-plus/pull/52

    It may help. If so, we just push it in master.

    I don't see a difference. It is still bad.

    Well, you did a great job with the git bisect. You just confirmed that it is about ncurses.

    Best Regards, Nil
    --- GoldED+/LNX 1.1.5
    * Origin: Linux 2.6.32-042stab145.3 (1:16/101)
  • From Wilfred van Velzen@2:280/464 to Vitaliy Aksyonov on Wed Feb 7 18:14:16 2024
    Hi Vitaliy,

    On 2024-02-07 17:33:31, I wrote to you:

    I updated from GED+LNX 1.1.5-b20161221 to 1.1.5-b20240205
    yesterday. (Compiled it myself using cmake)

    Now linedrawing characters are not showing correctly.

    Could you use git bisect to find the version which has broken this
    functionality?

    I'll try.

    I didn't know about the bisect function in git. Nice function!

    Here's the final output:

    # git bisect good
    8e9f3518ac9b3b32676e7b7563e92cc44e7b5ba7 is the first bad commit
    commit 8e9f3518ac9b3b32676e7b7563e92cc44e7b5ba7
    Author: Vitaliy Aksyonov <gbmr@i.ua>
    Date: Fri Oct 6 10:44:41 2023 -0600

    improve ncurses init/deinit

    This change allows seeing help on Linux when started with parameter '-?' or
    '-H'. Trailing critical log messages will be printed too.

    :040000 040000 6f0c0d4067d3333e6b152216057a7767b7072950 ee3dbc0486e0bb9ad4399c8852a7488af1fafd5c M docs
    :040000 040000 72b4131630052e6dc0d6079f7455bc4b04c7ff02 414d948a40e8ab1821f59d30f56ca0608e1b68c6 M golded3
    :040000 040000 9fcdacf4846f3b95b5e8571730a023ffb295506c c09f5edeb8998b939bd8d07667932966c9537164 M goldlib


    Bye, Wilfred.

    --- FMail-lnx64 2.2.1.0
    * Origin: FMail development HQ (2:280/464)
  • From Wilfred van Velzen@2:280/464 to Vitaliy Aksyonov on Wed Feb 7 18:42:42 2024
    Hi Vitaliy,

    On 2024-02-07 09:48:30, you wrote to me:

    Could you also thy this pull request https://github.com/golded-plus/golded-plus/pull/52

    It may help. If so, we just push it in master.

    I don't see a difference. It is still bad.


    Bye, Wilfred.

    --- FMail-lnx64 2.2.1.0
    * Origin: FMail development HQ (2:280/464)
  • From Wilfred van Velzen@2:280/464 to Nil Alexandrov on Wed Feb 7 21:11:56 2024
    Hi Nil,

    On 2024-02-07 21:00:50, you wrote to me:

    Could you also thy this pull request
    https://github.com/golded-plus/golded-plus/pull/52

    It may help. If so, we just push it in master.

    I don't see a difference. It is still bad.

    Well, you did a great job with the git bisect. You just confirmed that it is about ncurses.

    On the other hand, it didn't seem to make things worse either, so it's probably save to pull it in...


    Bye, Wilfred.

    --- FMail-lnx64 2.2.1.0
    * Origin: FMail development HQ (2:280/464)
  • From Wilfred van Velzen@2:280/464 to Nil Alexandrov on Thu Feb 8 09:30:52 2024
    Hi Nil,

    On 2024-02-07 17:21:34, I wrote to you:

    Here is a temporary workaround for you. Before running GoldED, just
    run

    tput init

    It doesn't help for the linedrawing characters inside a message.

    I'll check tomorrow what happens in a remote terminal.

    I don't see a difference in my remote terminal either, when using 'tput init' first.


    Bye, Wilfred.

    --- FMail-lnx64 2.2.1.0
    * Origin: FMail development HQ (2:280/464)