open https://gitlab.synchro.net/main/sbbs/-/issues/889

```
DigitalMan: I'm running the terminal-abstraction branch now on cvs.synchro.net DigitalMan: I see the line counter /auto-pause isn't working right
DigitalMan: e.g. there's a blank line before messages when new-scanning that's not normally there
DigitalMan: here's what looks like on master: https://1drv.ms/i/s!ApZPvWcrEaRQgZHvOw6Z8IRccjFIgt8?e=F86G2A
DigitalMan: Actually, that's the terminal-abstraction branch (has the blank line)
DigitalMan: here's what it looks like from master: https://1drv.ms/i/s!ApZPvWcrEaRQgZHvPCb5kKfKI-T8oK4?e=2ZPWgb
DigitalMan: another, different example: the xtrn->doors menu on master (vert.synchro.net) pauses before the title scrolls off: https://1drv.ms/i/s!ApZPvWcrEaRQgZHvPVt1Z2OBXxE-PIE?e=HmQBJk
DigitalMan: but not on the terminal-abstraction branch: https://1drv.ms/i/s!ApZPvWcrEaRQgZHvPhOQGu_BBR2dmZ0?e=aa8JvD
DigitalMan: while in getstr insert mode (e.g. hitting Ctrl-V while being prompted for an email subject) and then hitting Ctrl-U or Ctrl-T (anything that save/restoresline) the prompt disappears
DigitalMan: (this one I observed and reported before and I thought you'd fixed) DigitalMan: there's extra hit-a-key pauses before screen-clears when view general text files
DigitalMan: that's probably enough for now, but pretty easy to see the differences by comparing vert and cvs right now
```

Putting this here so it doesn't get lost. Will look once my system updates are done.
--- SBBSecho 3.23-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/issues/889#note_6805

None of these seem to be occurring.
--- SBBSecho 3.24-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/issues/889#note_6812

Where did you test? I reverted vert back to the master branch.
--- SBBSecho 3.24-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/issues/889#note_6813

```
■ Main ■ 0:06:39 [4] fsxNet [6] FSX NET: I

Info: V

Synchronet BBS for Linux Version 3.20 Debug

Revision E Mar 23 2025 23:45 SMBLIB 3.10 GCC 12.2.0

https://gitlab.synchro.net - master/9a746495e
```
--- SBBSecho 3.24-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/issues/889#note_6817

Since I'm guessing that you're depending on cvs/git.synchro.net for your testing (?), I've switched it back over to the terminal-abstraction branch for now:
```
■ Main ■ 0:00:07 [4] fsxNet [6] FSX NET: I

Info: V

Synchronet BBS for Linux Version 3.20 Debug

Revision E Mar 25 2025 08:35 SMBLIB 3.10 GCC 12.2.0

https://gitlab.synchro.net - terminal-abstraction/7f6756a93
```
--- SBBSecho 3.24-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/issues/889#note_6818

Rather than renaming `lastlinelen` to `lastcrcol`, I would *add* `lastcrcol` and when a newline is sent, copy `lastcrcol` to `lastlinelen`.
--- SBBSecho 3.24-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/issues/889#note_6820

The first issue appears to be fixed

The last issue I can reproduce locally no (previously it wasn't clear this was specifically at the subject entry prompt) and it's a lot worse when blink blinks.

I'll get to the second issue after the last one is fixed.
--- SBBSecho 3.24-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/issues/889#note_6821

I'm not seeing extra blank link before the message header during new scan now, so yeah, I guess it was fixed (?).
--- SBBSecho 3.24-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/issues/889#note_6822

Looks like the extra blank line here was fixed too:
```
Upload File

Filename:

[√] Start batch upload? Yes

1.5T bytes free

[Y] YMODEM-1K (SEXYZ) [~] YMODEM-G-stdio (SEXYZ)
```
--- SBBSecho 3.24-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/issues/889#note_6825

Ok, last issue should be fixed now too... I did do one thing that might have fixed the middle one, but I still don't have a repro, so I'm not certain.
--- SBBSecho 3.24-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/issues/889#note_6826

Looking better. The "Games" door menu still isn't pausing before rolling off the top of the ANSI graphic however.
--- SBBSecho 3.24-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/issues/889#note_6826

Looking better. The "Games" door menu (on cvs.synchro.net) still isn't pausing before rolling off the top of the ANSI graphic however.
--- SBBSecho 3.24-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/issues/889#note_6829

Games door menu should be fixed now. newline() and line_feed() weren't calling pause() because they bypass outchar() now.
--- SBBSecho 3.24-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/issues/889#note_6831

Games door menu now pauses as should.
--- SBBSecho 3.24-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/issues/889#note_6832

See several "sent broken ANSI sequence" during logon:
```
Mar 25 16:46:26 git sbbs[1226857]: term Node 11 <Digital Man> (0001) Digital Man Fast-Logon 0 - 6
Mar 25 16:46:27 git sbbs[1226857]: term Node 11 <Digital Man> CTerm query response: [=1;45;99;0;0;0;0n
Mar 25 16:46:27 git sbbs[1226857]: term Node 11 <Digital Man> CTerm query response: [=3;16;8n
Mar 25 16:46:27 git sbbs[1226857]: term Node 11 <Digital Man> activate: cp437 slot 0 >= 45
Mar 25 16:46:27 git sbbs[1226857]: term Node 11 <Digital Man> CTerm activate_font: 0 0
Mar 25 16:46:27 git sbbs[1226857]: term Node 11 <Digital Man> Sent broken ANSI sequence '[0;0 D'
Mar 25 16:46:27 git sbbs[1226857]: term Node 11 <Digital Man> CTerm query response: [=1;45;0;0;0;0;0n
Mar 25 16:46:27 git sbbs[1226857]: term Node 11 <Digital Man> CTerm activate_font result: 0
Mar 25 16:46:27 git sbbs[1226857]: term Node 11 <Digital Man> activate: digital slot 109 >= 45
Mar 25 16:46:27 git sbbs[1226857]: term Node 11 <Digital Man> CTerm load_font: slot 109 with 4096 bytes
Mar 25 16:46:27 git sbbs[1226857]: term Node 11 <Digital Man> CTerm activate_font: 1 109
Mar 25 16:46:27 git sbbs[1226857]: term Node 11 <Digital Man> Sent broken ANSI sequence '[1;109 D'
Mar 25 16:46:27 git sbbs[1226857]: term Node 11 <Digital Man> CTerm query response: [=1;45;0;0;109;0;0n
Mar 25 16:46:27 git sbbs[1226857]: term Node 11 <Digital Man> CTerm activate_font result: 0
Mar 25 16:46:27 git sbbs[1226857]: term Node 11 <Digital Man> activate: gothical slot 115 >= 45
Mar 25 16:46:27 git sbbs[1226857]: term Node 11 <Digital Man> CTerm load_font: slot 115 with 4096 bytes
Mar 25 16:46:27 git sbbs[1226857]: term Node 11 <Digital Man> CTerm activate_font: 2 115
Mar 25 16:46:28 git sbbs[1226857]: term Node 11 <Digital Man> Sent broken ANSI sequence '[2;115 D'
Mar 25 16:46:28 git sbbs[1226857]: term Node 11 <Digital Man> CTerm query response: [=1;45;0;0;109;115;0n
Mar 25 16:46:28 git sbbs[1226857]: term Node 11 <Digital Man> CTerm activate_font result: 0
Mar 25 16:46:28 git sbbs[1226857]: term Node 11 <Digital Man> activate: computer slot 106 >= 45
Mar 25 16:46:28 git sbbs[1226857]: term Node 11 <Digital Man> CTerm load_font: slot 106 with 4096 bytes
Mar 25 16:46:28 git sbbs[1226857]: term Node 11 <Digital Man> CTerm activate_font: 3 106
Mar 25 16:46:28 git sbbs[1226857]: term Node 11 <Digital Man> Sent broken ANSI sequence '[3;106 D'
Mar 25 16:46:28 git sbbs[1226857]: term Node 11 <Digital Man> CTerm query response: [=1;45;0;0;109;115;106n
Mar 25 16:46:28 git sbbs[1226857]: term Node 11 <Digital Man> CTerm activate_font result: 0
Mar 25 16:46:28 git sbbs[1226857]: term Node 11 <Digital Man> Executing external: ?logonlist -l
Mar 25 16:46:29 git sbbs[1226857]: term Node 11 <Digital Man> Printing file: /sbbs/data/msgs/auto.msg
```
--- SBBSecho 3.24-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/issues/889#note_6835

Games pause fix updated, only newline() would pause, line_feed() would not.
--- SBBSecho 3.24-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/issues/889#note_6837

ansiState_intermediate parsing fixed.
--- SBBSecho 3.24-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/issues/889#note_6841

master branch using a 25 line terminal and auto-pause enabled:
```
console.newline(30) // no pause
console.linefeed(30) // no pause
```
This branch, same test:
```
console.newline(30) // no pause
console.linefeed(30) // pause
```
--- SBBSecho 3.24-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/issues/889#note_6843

Can you start with a console.clearscreen() and test both with and without some text printed followed by either a newline() or a \\r\\n before? Also, does it have the latest line_feed() change? Those are both very sensitive to the starting state.
--- SBBSecho 3.24-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/issues/889#note_6844

Yes, this is using the latest.
--- SBBSecho 3.24-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/issues/889#note_6845

I just using the ;eval command from the main menu of the default command shell for this test.
--- SBBSecho 3.24-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/issues/889#note_6846

`console.clear(); console.linefeed(30);` does the same thing (no pause on master, pause on this branch)
--- SBBSecho 3.24-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/issues/889#note_6848

"Fixed"?
--- SBBSecho 3.24-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/issues/889#note_6851

No. I think this better illustrates the problem:
master branch:
```
console.clear(); console.linefeed(30); console.line_counter
```
result is 0.
this branch:
result is 30.

The first blank lines should not be incrementing the line counter. In your branch, they are.
--- SBBSecho 3.24-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/issues/889#note_6859

And really, console.linefeed() isn't supposed to changing the line_counter at all, so that's likely the issue.
--- SBBSecho 3.24-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/issues/889#note_6851

No. I think this better illustrates the problem:
master branch:
```
console.clear(); console.linefeed(30); console.line_counter
```
result is 0.

this branch: result is 30.

The first blank lines should not be incrementing the line counter. In your branch, they are (or maybe not, see next comment).
--- SBBSecho 3.24-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/issues/889#note_6872

Ah, I missed the fall-through on the FF case.
--- SBBSecho 3.24-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/issues/889#note_6874

Fixed.
--- SBBSecho 3.24-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/issues/889#note_6875

I can add line counter behaviour to the discussion points. It does behave differently on this branch, but it _should_ act the same in places that currently rely on it.
--- SBBSecho 3.24-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/issues/889#note_6937

Fixed.
--- SBBSecho 3.24-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

close https://gitlab.synchro.net/main/sbbs/-/issues/889
--- SBBSecho 3.24-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)